Added: close button in the tag modal (#85zrvzfqv) #198
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adityasharma7
suggested changes
Apr 12, 2023
adityasharma7
suggested changes
Apr 18, 2023
src/store/modules/product/actions.ts
Outdated
| dispatch('updateQuery') | ||
| }, | ||
|
|
||
| async updateAppliedFilterOperator({ commit, state, dispatch }, payload) { | ||
| const appliedFilters = JSON.parse(JSON.stringify((state.appliedFilters as any)[payload.type][payload.id])) | ||
| appliedFilters.operator = payload.value; | ||
| commit(types.PRODUCT_FILTER_UPDATED, {id: payload.id, type: payload.type, value: appliedFilters}) |
There was a problem hiding this comment.
Why this change is needed?
This action should only allow operator change. With this change, this action is updating Applied Filters like the above action with an exception of querying on condition
adityasharma7
approved these changes
Apr 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues
Closes #193
Short Description and Why It's Useful
Added a close/check button to save the applied tag filters in the modal. Previously, the tags were applied directly on checking/selecting but now the changes will take effect after clicking the check button.
Screenshots of Visual Changes before/after (If There Are Any)
Screencast.from.10-04-23.05.45.47.PM.IST.webm
IMPORTANT NOTICE - Remember to add changelog entry
Contribution and Currently Important Rules Acceptance