Fixed: AutoCompleteSolrFacet API fails due to invalid characters when using GET method (#2gagqqt) #127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… using GET method (#2gagqqt) Error: Invalid character found in the request target [/api/AutoCompleteSolrFacet?facetToSelect=tagsFacet&docType=PRODUCT&coreName=enterpriseSearch&searchfield=tags&jsonQuery=encodeURIComponent({%22query%22:%22*:*%22,%22filter%22:%20[%22docType:PRODUCT%22]})&noConditionFind=N&q=&term=&offset=&limit=%2210%22 ]. The valid characters are defined in RFC 7230 and RFC 3986 Issue: If you use an upper version of Tomcat 8.5 it throws this exception if the URL path contains '[' and ']'. For older versions, it works. Solution: Used paramsSerializer available with axios to serialize params and qs npm package (https://www.npmjs.com/package/qs) for stringifying the parameters. When passing object to qs, bracket or dot notation is returned as output. Handled the case by stringify the object before passing to qs.stringify() method
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Error:
Invalid character found in the request target [/api/AutoCompleteSolrFacet?facetToSelect=tagsFacet&docType=PRODUCT&coreName=enterpriseSearch&searchfield=tags&jsonQuery=encodeURIComponent({%22query%22:%22*:*%22,%22filter%22:%20[%22docType:PRODUCT%22]})&noConditionFind=N&q=&term=&offset=&limit=%2210%22 ]. The valid characters are defined in RFC 7230 and RFC 3986
Issue:
If you use an upper version of Tomcat 8.5 it throws this exception if the URL path contains '[' and ']'. For older versions, it works.
Solution:
Used paramsSerializer available with axios to serialize params and qs npm package (https://www.npmjs.com/package/qs) for stringifying the parameters.
When passing object to qs, bracket or dot notation is returned as output. Handled the case by stringify the object before passing to qs.stringify() method
Related Issues
Closes #
Short Description and Why It's Useful
Screenshots of Visual Changes before/after (If There Are Any)
IMPORTANT NOTICE - Remember to add changelog entry
Contribution and Currently Important Rules Acceptance