Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add AWS Logo to footer #6403

Merged
merged 1 commit into from
May 3, 2024
Merged

Conversation

royallsilwallz
Copy link
Contributor

@royallsilwallz royallsilwallz commented May 2, 2024

What type of PR is this?

  • 🍕 Feature

Related Issue

Describe this PR

Add AWS Logo to the footer section.

Screenshots

image

Copy link

sonarqubecloud bot commented May 2, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@nicolelaine
Copy link

Logo placement looks good, thanks so much!

@ramyaragupathy
Copy link
Member

@varun2948 @royallsilwallz - could we also make this configurable, so that it is not a must for other TM instances that 's hosted on different cloud services? We need not rush towards a solution to bring it for the current release. May be we can use a separate PR for another release to make this configurable. Let me know your thoughts.

cc @nicolelaine @dakotabenjamin @manjitapandey

@royallsilwallz
Copy link
Contributor Author

Yeah we can do that if required !

@ramyaragupathy
Copy link
Member

merging it for now, we can think about configuration options for a later release.

@ramyaragupathy ramyaragupathy merged commit 038f744 into develop May 3, 2024
9 of 10 checks passed
@ramyaragupathy ramyaragupathy added this to the v4.7.2 milestone May 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Integrating AWS logo within footer section
4 participants