Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Infra: tm-exporter lambda function using terragrunt. #6189

Merged
merged 13 commits into from
Jan 29, 2024

Conversation

mahesh-naxa
Copy link
Collaborator

Note:

@mahesh-naxa
Copy link
Collaborator Author

hi @dakotabenjamin i have added added raw_data_api & active_projects_api_base_url as inputs on all sets of dev,stag,prod so, only TF_VAR_rawdata_api_auth_token remains to be set as an environment var.

@mahesh-naxa mahesh-naxa marked this pull request as ready for review January 8, 2024 15:14
Copy link
Member

@dakotabenjamin dakotabenjamin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm setting my review as "Request Changes" because everything looks good but I need some clarification. Once the questions are addressed here in in the TM-Extractor repo, I think this is good to merge.

# needs to deploy a different module version, it should redefine this block with a different ref to override the
# deployed version.
terraform {
# Sourcing from here rn, updating to a release from https://github.com/hotosm/TM-Extractor/ later.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In order to make my tests work, I had to replace the source with my local build of TM-extractor where I set the required terraform version to ~>1.6.0. See hotosm/TM-Extractor#3 for more details.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, that would be nice to have minor patches allowed, only thing is that once we have our CircleCi config for deployments how would we make sure they align. Else i am all okay.
I have updated TM-Extractor's v.1.0.1 to be source. I see it has updated code on =1.6.0.

# Set common variables for the environment. This is automatically pulled in in the root terragrunt.hcl configuration to
# feed forward to the child modules.

locals {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should these be set with example defaults as a env.hcl.example with README instructions to replace and rename?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it would be up to us to have it already created. I have updated README.md within scripts/aws/lambda/TM-Extrator/ with this information.
@dakotabenjamin However i had no clue on what stag/prod input vars will be for account_name, account_region. Can you have that updated for stag/prod.

Copy link

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@dakotabenjamin dakotabenjamin merged commit 740e3a2 into develop Jan 29, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Export tool integration: infrastructure tasks
3 participants