add: sonarcube suggestions on disable package install recommends #6087
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
|
Kudos, SonarCloud Quality Gate passed!
|
|
Add:
|
eternaltyro
suggested changes
Oct 30, 2023
| @@ -4,18 +4,13 @@ FROM python:${PYTHON_IMG_TAG}-bookworm | |||
| RUN mkdir -p /usr/src/app | |||
| WORKDIR /usr/src/app | |||
|
|
|||
| ENV PATH="/usr/src/app/__pypackages__/${PYTHON_IMG_TAG}/bin:$PATH" \ | |||
There was a problem hiding this comment.
why is this being removed?
There was a problem hiding this comment.
@eternaltyro python stuff are inherited from python:3.10-bookworm base image. idk why PATH and PYTHONPATH are updated to use /usr/src/app/__pypackages__/${PYTHON_IMG_TAG}/bin where nothing exists.
It was also flagged by sonarcube. these changes are non destructive.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes Sunarcube Errors and Suggestions on CI