Replace Pydantic ValueError with standard ValueError #6
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current implementation of
pydantic_core.ValidationError
did not work.If the
except
was triggered herewe simply got:
no constructor defined
.This is because pydantic ValidationError cannot be used directly.
Correct usage would be via the
from_exception_data
static method:However, IMO, this is overly complicated and we don't need to use pydantic for it.
A simple ValueError will suffice & is more maintainable.
Additional context