Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Task splitting algorithm fails to split tasks when custom data extracts uploaded #1176

Closed
manjitapandey opened this issue Feb 7, 2024 · 4 comments · Fixed by #1183
Closed
Assignees
Labels
bug Something isn't working frontend Related to frontend code

Comments

@manjitapandey
Copy link
Contributor

Describe the bug
Task splitting algorithm fails to split tasks. The API shows 200 but response shows null in the features. This can be reproduced by choosing custom data extracts.

To Reproduce
Steps to reproduce the behavior:

  1. Go to create project
  2. Click on Upload custom data extracts
  3. select Task splitting algorithm
  4. See error

Expected behavior
Smooth task splitting and project creation

Screenshots
image

@manjitapandey
Copy link
Contributor Author

Related: #1172

@spwoodcock
Copy link
Member

I think this is probably a frontend issue too - the custom data extract is not passing to either task splitting or the generate endpoints.

@spwoodcock spwoodcock added frontend Related to frontend code and removed backend Related to backend code labels Feb 8, 2024
@spwoodcock spwoodcock assigned spwoodcock and unassigned nrjadkry Feb 8, 2024
@spwoodcock spwoodcock moved this from Up Next to In Progress in Field Mapping Tasking Manager (FMTM) Feb 8, 2024
@ivangayton
Copy link
Collaborator

I'm about to start a brand-new dive into the splitting algorithm starting Monday. I suspect that in at least some situations, there are non-replicable failures. The splitting algorithm can probably fail given some kinds of broken OSM data, which wouldn't be replicable unless you tried to split exactly the same AOI with exactly the same parameters.

Basically I think we need:

  • Me to provide better failure handling in the SQL
  • Front end to provide more information about what happened when failures occur in the splitter
  • Unit tests using data that's known to work so that if it breaks for some other reason we can quickly detect that

@spwoodcock
Copy link
Member

spwoodcock commented Feb 8, 2024

We have point 3 covered - I wrote quite a few tests for fmtm-splitter 😄

You can run them with:

docker compose run --rm splitter pytest

With this in mind, I just wrote a very quick guide to testing updates to fmtm-splitter visually: https://hotosm.github.io/fmtm-splitter/testing-visually/
Hopefully it helps debugging @ivangayton

Also related hotosm/fmtm-splitter#24

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working frontend Related to frontend code
Projects
Development

Successfully merging a pull request may close this issue.

4 participants