Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom data extracts are not passed through during project creation #1172

Closed
manjitapandey opened this issue Feb 6, 2024 · 3 comments · Fixed by #1183
Closed

Custom data extracts are not passed through during project creation #1172

manjitapandey opened this issue Feb 6, 2024 · 3 comments · Fixed by #1183
Assignees
Labels
bug Something isn't working frontend Related to frontend code

Comments

@manjitapandey
Copy link
Contributor

Describe the bug
The custom data is not visible on map step 4 of project creation. No API is called for loading custom data extracts.

To Reproduce
Steps to reproduce the behavior:

  1. Go to create project step 4
  2. Upload custom data extracts
  3. See error

Expected behavior
custom data extract to be visible on map

Screenshots
image

@manjitapandey manjitapandey added the bug Something isn't working label Feb 6, 2024
@spwoodcock
Copy link
Member

Is the geojson valid? Perhaps it threw an error silently.

I just uploaded a custom data extract:
image

Related #1145 (uploading flatgeobuf doesn't work properly, but geojson should)

@spwoodcock
Copy link
Member

The bbox
kathmandu.txt

The extract
kathmandu_extract.txt

They are txt file, as geojson is not supported by github.

@spwoodcock spwoodcock changed the title Unable to upload custom data extracts Custom data extracts are not passed through during project creation Feb 6, 2024
@spwoodcock spwoodcock added the frontend Related to frontend code label Feb 6, 2024
@spwoodcock
Copy link
Member

Oops accidentally deleted my previous comment.

So data extracts are not getting passed through to the generate stage correctly - only a false value gets passed:

image

Two things to investigate:

  • Are the geojson extracts correctly loading on the split-tasks stage? Is there adequate error handling here if the geojson is not valid?
  • Why the geojson is not passed to the generate endpoint, but instead a boolean value is.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working frontend Related to frontend code
Projects
Development

Successfully merging a pull request may close this issue.

2 participants