Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test/backend test cases for fAIr #259

Merged
merged 4 commits into from
Aug 6, 2024

Conversation

nifedara
Copy link
Contributor

@nifedara nifedara commented Jul 15, 2024

What does this PR do?

To solve the issue: Implement Backend Test Cases for fAIr

Consideration

  • Adds factories to isolate the test data
  • Excludes callback endpoint from coverage
  • Increases coverage from 64% to 76%

image

@nifedara
Copy link
Contributor Author

Happy Monday, @kshitijrajsharma. Kindly review this.
Thanks

@kshitijrajsharma
Copy link
Member

Do you want to add github action .yaml on this PR ? or sep one ?

backend/tests/test_endpoints.py Outdated Show resolved Hide resolved
backend/tests/test_endpoints.py Outdated Show resolved Hide resolved
backend/tests/test_endpoints.py Show resolved Hide resolved
@kshitijrajsharma
Copy link
Member

Kindly rebase your branch and now afterwards test cases should be running

@nifedara nifedara marked this pull request as ready for review August 6, 2024 11:39
@kshitijrajsharma kshitijrajsharma merged commit fbb7691 into hotosm:master Aug 6, 2024
1 check failed
jeafreezy pushed a commit to jeafreezy/fAIr that referenced this pull request Sep 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants