Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update CONTRIBUTING.md #204

Merged
merged 1 commit into from
Jan 15, 2024
Merged

Update CONTRIBUTING.md #204

merged 1 commit into from
Jan 15, 2024

Conversation

vickystickz
Copy link
Contributor

Added Code Contributions message

@vickystickz
Update CONTRIBUTING.md
515a74b 
Added Code Contributions message
petya-kangalova
petya-kangalova approved these changes Jan 10, 2024
View reviewed changes
Copy link
Contributor

@petya-kangalova petya-kangalova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, approving.

@petya-kangalova
Copy link
Contributor

@kshitijrajsharma can you check and merge?

@kshitijrajsharma
Copy link
Member

Contributing needs more information , For eg : There should be steps about understanding the license , navigating to readme , follow the ethical guidelines , coding standards , proper branching name and PR methods ! We can work on it future , Merging this PR for now to start with

@kshitijrajsharma kshitijrajsharma merged commit 3307cef into hotosm:master Jan 15, 2024
1 of 2 checks passed
@vickystickz
Copy link
Contributor Author

Contributing needs more information , For eg : There should be steps about understanding the license , navigating to readme , follow the ethical guidelines , coding standards , proper branching name and PR methods ! We can work on it future , Merging this PR for now to start with

Alright noted

@petya-kangalova
Copy link
Contributor

@kshitijrajsharma 100%, did we have to wait for all remaining open PRs to be approved (that had that additional content) before merging? I thought they can be merged 1 by 1 and then have thee complete contributor guidance.

jeafreezy pushed a commit to jeafreezy/fAIr that referenced this pull request Sep 18, 2024
@kshitijrajsharma
Merge pull request hotosm#204 from vickystickz/patch-1
b012cee 
Update CONTRIBUTING.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@petya-kangalova petya-kangalova petya-kangalova approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vickystickz @petya-kangalova @kshitijrajsharma