Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only accepted features should be included in the download data #223

Closed
omranlm opened this issue Feb 21, 2024 · 5 comments
Closed

Only accepted features should be included in the download data #223

omranlm opened this issue Feb 21, 2024 · 5 comments

Comments

@omranlm
Copy link
Contributor

omranlm commented Feb 21, 2024

Describe the bug
In the mapping page, only accepted features should be included in the download .. or clearly declare that the download would include all predicated features

To Reproduce
Steps to reproduce the behavior:

  1. Go to mapping page, for example https://fair-dev.hotosm.org/start-mapping/120
  2. Click on run prediction
  3. Scroll down see the download as geojson button under options section
  4. Download the data and visualize it in QGIS and it will include all features

Expected behavior
We should have the selected features only downloaded
Another option is to clearly say it is downloading all data

Screenshots
image

@omranlm omranlm added the bug Something isn't working label Feb 21, 2024
@omranlm omranlm self-assigned this Feb 21, 2024
@omranlm
Copy link
Contributor Author

omranlm commented Feb 21, 2024

CC @kshitijrajsharma

@natrimmer
Copy link
Contributor

natrimmer commented Jul 10, 2024

I'd like to ask clarifying questions with an example.

Here is a predication with some accepted features:
Screenshot 2024-07-10 at 14 54 20

And here is the downloaded GeoJSON from that prediction represented in QGIS:
Screenshot 2024-07-10 at 14 56 32

@omranlm is suggesting that if there are accepted features within the prediction that the GeoJSON downloaded when rendered should look like this:
Screenshot 2024-07-10 at 15 03 37

Is that a correct understanding of the problem? As for the exact feature, maybe it could end up being two buttons. One for all predicted features represented in the GeoJSON, and once the first feature is accepted an additional button displays for downloaded just the accepted feaetures in GeoJSON format.

@kshitijrajsharma
Copy link
Member

I'd like to ask clarifying questions with an example.

Here is a predication with some accepted features:

Screenshot 2024-07-10 at 14 54 20

And here is the downloaded GeoJSON from that prediction represented in QGIS:

Screenshot 2024-07-10 at 14 56 32

@omranlm is suggesting that if there are accepted features within the prediction that the GeoJSON downloaded when rendered should look like this:

Screenshot 2024-07-10 at 15 03 37

Is that a correct understanding of the problem? As for the exact feature, maybe it could end up being two buttons. One for all predicted features represented in the GeoJSON, and once the first feature is accepted an additional button displays for downloaded just the accepted feaetures in GeoJSON format.

That's correct understanding!

@omranlm
Copy link
Contributor Author

omranlm commented Jul 11, 2024

The 2 buttons idea sounds like a better solution.

We also got community feedback while piloting with HOT hubs to define an area of interest and run prediction for the whole area then share predictions as geojson, so that could be a 3rd button that takes are of interest and returns geojson (it might need queuing as response time would depend on the size of the area of interest)

@natrimmer
Copy link
Contributor

So three different GeoJSON export options:

  1. Defined areas of interests within the dataset
  2. After running a prediction, all predicted features
  3. After accepting a feature, all accepted features

kshitijrajsharma added a commit that referenced this issue Sep 3, 2024
…nload

Closes #223 [Only accepted features should be included in the downloa…
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants