Improve error message when upsert records #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keyn4
reviewed
Dec 5, 2024
target_salesforce_v3/client.py
Outdated
| response_content = response.text if hasattr(response, 'text') else str(response) | ||
|
|
||
| error_message = f"Error: {e}, Response: {response_content}" |
There was a problem hiding this comment.
I think it's good 🙌 maybe we can also add the status code and the sink where it happened, also either here or in validate_response it would be good to log the request body and url just so it's easier for us to debug if an error happens.
keyn4
approved these changes
Dec 9, 2024
…esponse details - Updated log_error_message method to accept sink_name and log more detailed error messages, including response status code, URL, and request body. - Adjusted calls to log_error_message across ContactsSink, CampaignSink, and FallbackSink to pass the sink name for better context in error logs.
butkeraites-hotglue
force-pushed
the
feature/hgi-6844
branch
from
46507f6 to
f705ea0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.