Merge pull request #12 from hotgluexyz/fix/NoneBookmarkKey

fix empty bookmak key error
hotgluexyz · May 11, 2022 · c6968b9 · c6968b9
2 parents 3f15d99 + 9d290dd
commit c6968b9
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 6 deletions.
diff --git a/setup.py b/setup.py
@@ -3,7 +3,7 @@
 from setuptools import setup, find_packages
 
 setup(name='tap-chargebee',
-      version='1.0.15',
+      version='1.0.16',
       description='Singer.io tap for extracting data from the Chargebee API',
       author='[email protected]',
       classifiers=['Programming Language :: Python :: 3 :: Only'],

diff --git a/tap_chargebee/streams/base.py b/tap_chargebee/streams/base.py
@@ -190,11 +190,11 @@ def sync_data(self):
 
                 if bookmark_key is not None:
                     for item in to_write:
-                        #if item.get(bookmark_key) is not None:
-                        max_date = max(
-                            max_date,
-                            parse(item.get(bookmark_key))
-                        )
+                        if item.get(bookmark_key) is not None:
+                            max_date = max(
+                                max_date,
+                                parse(item.get(bookmark_key))
+                            )
 
             if bookmark_key is not None:
                 self.state = incorporate(