add alt + h2 for testing

hotgeart · Mar 10, 2020 · 6abbae8 · 6abbae8
1 parent cd512f2
commit 6abbae8
Show file tree

Hide file tree

Showing 4 changed files with 18 additions and 11 deletions.
diff --git a/dist/demo.css b/dist/demo.css
diff --git a/dist/index.html b/dist/index.html
@@ -12,27 +12,32 @@ <h1>A11y Carousel</h1>
     <div id="my-slider">
       <div>
         <a href="#">
-          <img src="https://i.picsum.photos/id/1057/970/400.jpg" alt="" />
+          <h2>Photo 0</h2>
+          <img src="https://i.picsum.photos/id/1057/970/400.jpg" alt="photo 0" />
         </a>
       </div>
       <div>
         <a href="#">
-          <img src="https://i.picsum.photos/id/605/970/400.jpg" alt="" />
+          <h2>Photo 1</h2>
+          <img src="https://i.picsum.photos/id/605/970/400.jpg" alt="photo 1" />
         </a>
       </div>
       <div>
         <a href="#">
-          <img src="https://i.picsum.photos/id/218/970/400.jpg" alt="" />
+          <h2>Photo 2</h2>
+          <img src="https://i.picsum.photos/id/218/970/400.jpg" alt="photo 2" />
         </a>
       </div>
       <div>
         <a href="#">
-          <img src="https://i.picsum.photos/id/419/970/400.jpg" alt="" />
+          <h2>Photo 3</h2>
+          <img src="https://i.picsum.photos/id/419/970/400.jpg" alt="photo 3" />
         </a>
       </div>
       <div>
         <a href="#">
-          <img src="https://i.picsum.photos/id/1054/970/400.jpg" alt="" />
+          <h2>Photo 4</h2>
+          <img src="https://i.picsum.photos/id/1054/970/400.jpg" alt="photo 4" />
         </a>
       </div>
     </div>

diff --git a/src/a11y-carousel.js b/src/a11y-carousel.js
@@ -356,12 +356,11 @@ class A11yCarousel {
       this.setSize();
     } else {
       this.setSize();
+      // If there's imgs and when need to wait them
+      imgs[imgs.length-1].addEventListener('load', () => {
+        this.setSize();
+      });
     }
-
-    // If there's imgs and when need to wait them
-    imgs[imgs.length-1].addEventListener('load', () => {
-      this.setSize();
-    });
   };
 
   /**

diff --git a/src/demo.scss b/src/demo.scss
@@ -65,4 +65,7 @@ button {
   right: 0;
   bottom: 0;
   text-align: center;
+}
+h2 {
+  text-align: center;
 }