Added a workaround for Safari and BigUint64Array #411
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The release notes for Safari version 121 say that
BigUint64ArrayandBigInt64Arrayare supported (caniuse says it was released in October 2021), but in practice we've found Safari browsers where they aren't defined.To avoid a
ReferenceErroron these browsers we can use a shim class which will throw an exception whenever you try to construct these unsupported types. According to zloirock/core-js#381 and thecore-jsREADME it isn't possible to polyfill bigint, so this is probably the best we can do.Fixes #412.