Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Embedded Resources #273

Merged
merged 16 commits into from
Aug 31, 2021
Merged

Embedded Resources #273

merged 16 commits into from
Aug 31, 2021

Conversation

Michael-F-Bryan
Copy link
Contributor

Fixes #228.

@Michael-F-Bryan Michael-F-Bryan added area - codegen The code gets generated when compiling a Rune area - runefile The parsing and analysis of Runefiles area - runtime The Rust Rune runtime category - enhancement New feature or request effort - hard This should be pretty simple to fix labels Aug 26, 2021
@Michael-F-Bryan
Copy link
Contributor Author

Michael-F-Bryan commented Aug 31, 2021 •
edited
Loading

Ah, it looks like CI isn't able to find our embedded resources because of rust-lang/rust#56639.

It's strange that this works fine on my computer, though (edit: ignore me, I was mistaken)

@Michael-F-Bryan Michael-F-Bryan merged commit 8a2fc87 into master Aug 31, 2021
@Michael-F-Bryan Michael-F-Bryan deleted the 228-embedded-resources branch August 31, 2021 07:05
@Michael-F-Bryan Michael-F-Bryan mentioned this pull request Sep 27, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
area - codegen The code gets generated when compiling a Rune area - runefile The parsing and analysis of Runefiles area - runtime The Rust Rune runtime category - enhancement New feature or request effort - hard This should be pretty simple to fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Embedded resources
1 participant
@Michael-F-Bryan