Add api key screen #98
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Copilot wasn't able to review any files in this pull request.
Files not reviewed (14)
- app/src/main/java/dev/hossain/weatheralert/api/ApiModel.kt: Language not supported
- app/src/main/java/dev/hossain/weatheralert/api/WeatherApi.kt: Language not supported
- app/src/main/java/dev/hossain/weatheralert/data/ApiKey.kt: Language not supported
- app/src/main/java/dev/hossain/weatheralert/data/Models.kt: Language not supported
- app/src/main/java/dev/hossain/weatheralert/data/PreferencesManager.kt: Language not supported
- app/src/main/java/dev/hossain/weatheralert/data/UserPreferences.kt: Language not supported
- app/src/main/java/dev/hossain/weatheralert/data/WeatherRepository.kt: Language not supported
- app/src/main/java/dev/hossain/weatheralert/ui/addalert/AlertSettingsScreen.kt: Language not supported
- app/src/main/java/dev/hossain/weatheralert/ui/addapikey/ByoApiKeyScreen.kt: Language not supported
- app/src/main/res/drawable/abstract_mountain.xml: Language not supported
- app/src/main/res/drawable/clouds.xml: Language not supported
- app/src/main/res/drawable/earth_with_cloud.xml: Language not supported
- app/src/main/res/drawable/servers.xml: Language not supported
- app/src/test/resources/open-weather-overview-new-york.json: Language not supported
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #90
This pull request includes several changes to the weather alert application, focusing on adding new API functionality, improving user preferences management, and enhancing the user interface for API key handling. The most important changes include adding a new API endpoint for weather overview, updating the preferences manager to handle user-provided API keys, and modifying the user interface to prompt users to add their own API keys when necessary.
API Enhancements:
WeatherOverviewdata class and a new API endpointgetWeatherOverviewto validate API keys. (app/src/main/java/dev/hossain/weatheralert/api/ApiModel.kt,app/src/main/java/dev/hossain/weatheralert/api/WeatherApi.kt) [1] [2]Preferences Management:
PreferencesManagerto store and retrieve user-provided API keys usingDataStore. (app/src/main/java/dev/hossain/weatheralert/data/PreferencesManager.kt,app/src/main/java/dev/hossain/weatheralert/data/UserPreferences.kt) [1] [2] [3]User Interface:
AlertSettingsScreento includeSnackbarDataand navigate toBringYourOwnApiKeyScreenwhen prompting users to add their own API keys. (app/src/main/java/dev/hossain/weatheralert/ui/addalert/AlertSettingsScreen.kt) [1] [2] [3] [4] [5]Repository Changes:
isValidApiKeymethod inWeatherRepositoryto validate API keys by sending a basic API request. (app/src/main/java/dev/hossain/weatheralert/data/WeatherRepository.kt) [1] [2]Miscellaneous:
SnackbarDatadata class to handle snackbar messages with optional actions. (app/src/main/java/dev/hossain/weatheralert/data/Models.kt)