Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REFACTOR] Moved the requiresApiKey to service enum #308

Merged
merged 1 commit into from
Feb 8, 2025

Conversation

hossain-khan
Copy link
Owner

This pull request includes changes to refactor how the requiresApiKey property is managed within the WeatherForecastService class and its usage across the codebase. The main goal is to simplify the handling of API key requirements by moving the requiresApiKey property directly into the WeatherForecastService enum.

Refactoring API key requirement handling:

@hossain-khan hossain-khan self-assigned this Feb 8, 2025
@Copilot Copilot bot review requested due to automatic review settings February 8, 2025 13:31

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review any files in this pull request.

Files not reviewed (3)
  • app/src/main/java/dev/hossain/weatheralert/ui/UiExtensions.kt: Language not supported
  • app/src/main/java/dev/hossain/weatheralert/ui/settings/UserSettingsScreen.kt: Language not supported
  • data-model/src/main/java/dev/hossain/weatheralert/datamodel/WeatherForecastService.kt: Language not supported
Copy link

github-actions bot commented Feb 8, 2025

Code Coverage Report

View Coverage Report

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 28.82%. Comparing base (ccc13d9) to head (e976a1a).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #308      +/-   ##
==========================================
+ Coverage   28.69%   28.82%   +0.12%     
==========================================
  Files          49       49              
  Lines        1122     1117       -5     
  Branches       90       90              
==========================================
  Hits          322      322              
+ Misses        778      773       -5     
  Partials       22       22              

@hossain-khan hossain-khan merged commit 383d858 into main Feb 8, 2025
5 checks passed
@hossain-khan hossain-khan deleted the move-service-prop branch February 8, 2025 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants