Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UPDATE] Replaced "Settings" menu with overflow menu with more options #218

Merged
merged 3 commits into from
Jan 25, 2025

Conversation

hossain-khan
Copy link
Owner

@hossain-khan hossain-khan commented Jan 25, 2025

This pull request includes several updates to the CurrentAlertScreen in the weatheralert app, focusing on adding new functionality and improving the UI.

New functionality:

  • Added a new AboutAppClicked event to the CurrentWeatherAlertScreen class to handle clicks on the "About" menu item. [1] [2]
  • Created a new AppMenuItems composable function to display a dropdown menu with options for settings, sending feedback, and about.

UI improvements:

  • Modified the top app bar in the CurrentWeatherAlerts function to include a new weather alert icon and a dropdown menu for additional actions.
  • Added new drawable resources for feedback, open in new, and weather alert icons. [1] [2] [3]

Code cleanup:

  • Removed unused import for IconButton in CurrentAlertScreen.kt.
  • Added new imports for layout components used in the updated UI.

@hossain-khan hossain-khan self-assigned this Jan 25, 2025
@Copilot Copilot bot review requested due to automatic review settings January 25, 2025 00:09

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review any files in this pull request.

Files not reviewed (4)
  • app/src/main/java/dev/hossain/weatheralert/ui/alertslist/CurrentAlertScreen.kt: Language not supported
  • app/src/main/java/dev/hossain/weatheralert/ui/alertslist/MainMenuItems.kt: Language not supported
  • app/src/main/res/drawable/feedback_24dp.xml: Language not supported
  • app/src/main/res/drawable/open_in_new_24dp.xml: Language not supported
Copy link

github-actions bot commented Jan 25, 2025

Code Coverage Report

View Coverage Report

@codecov-commenter
Copy link

codecov-commenter commented Jan 25, 2025

Codecov Report

Attention: Patch coverage is 0% with 10 lines in your changes missing coverage. Please review.

Project coverage is 26.91%. Comparing base (79d79fd) to head (fdbdf9c).
Report is 9 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #218      +/-   ##
==========================================
- Coverage   27.16%   26.91%   -0.26%     
==========================================
  Files          43       44       +1     
  Lines         968      977       +9     
  Branches       84       84              
==========================================
  Hits          263      263              
- Misses        686      695       +9     
  Partials       19       19              

@hossain-khan hossain-khan merged commit c6dd102 into main Jan 25, 2025
4 checks passed
@hossain-khan hossain-khan deleted the add-menu-and-about branch January 25, 2025 00:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants