Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UPDATE] Removed scheme based deep linking. Using screen directly. #199

Merged
merged 1 commit into from
Jan 20, 2025

Conversation

hossain-khan
Copy link
Owner

Reverts most changes from #198

Closes #192

Need to handle this later:

onCreate action: android.intent.action.MAIN, bundle: Bundle[mParcelledData.dataSize=192], savedInstanceState: null

This pull request includes several changes to improve the handling of deep links in the MainActivity and related files. The most important changes include replacing URI-based deep link handling with Bundle-based handling, updating imports, and modifying the notification system to use the new deep link approach.

Deep link handling improvements:

Notification system update:

@hossain-khan hossain-khan self-assigned this Jan 20, 2025
@Copilot Copilot bot review requested due to automatic review settings January 20, 2025 20:01

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review any files in this pull request.

Files not reviewed (3)
  • app/src/main/java/dev/hossain/weatheralert/MainActivity.kt: Language not supported
  • app/src/main/java/dev/hossain/weatheralert/deeplinking/AppDeepLink.kt: Language not supported
  • app/src/main/java/dev/hossain/weatheralert/notification/Notification.kt: Language not supported
Reverts most changes from #198

Closes #192

Need to handle this later:
```
onCreate action: android.intent.action.MAIN, bundle: Bundle[mParcelledData.dataSize=192], savedInstanceState: null
```
@hossain-khan hossain-khan force-pushed the 192-deep-link-the-right-way branch from aeec94d to 5fa5dbb Compare January 20, 2025 20:03
@hossain-khan hossain-khan merged commit 9a6dbc9 into main Jan 20, 2025
3 checks passed
@hossain-khan hossain-khan deleted the 192-deep-link-the-right-way branch January 20, 2025 20:05
hossain-khan added a commit that referenced this pull request Jan 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deep linking to city alert from the notification
1 participant