Make service-worker-status more obviously dynamic #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gr2m
requested changes
Oct 6, 2016
| [data-service-worker="ready"] .service-worker.ready { | ||
| display: block; | ||
| display: block;i |
a Please enter the commit message for your changes. Lines starting
|
Thanks Ian 👍 Are you on twitter? We like giving shout outs to new contributors, only if you want of course :) |
|
twitter |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The service-worker-status class above the code on page 1 is not intuitively understood as a dynamic element. When I first read it, I skimmed right over it and assumed it was just some styled text.
By giving status its own paragraph, centering it and putting a simple border around the element, it will me more easy for humans to interpret it as dynamic. And important.