Throttling error for http conflict, fixing Issue #5 #7
Conversation
Visgean
changed the title
Visgean
changed the title
|
Thanks! Please, address my comments. I was thinking of some way to encapsulate this (if someone is polling the API for some number, she already did the same request and the library could just return what was loaded the last time in case it was requested before the limit... sort of caching to overcome small time granularity), but after all, being transparent about this error is probably the best way how to handle it for now. I'm going to merge this and release the new version soon. |
| import requests | ||
|
|
||
| from datetime import datetime, date |
There was a problem hiding this comment.
why this placement? I tend to cluster imports from std lib together
There was a problem hiding this comment.
It might only my thing but I usually do imports in following way:
import ...
from libs import ... - libs like django etc.
from core import ... - project modules
Usually its nicer to look at because from ... import ... are much longer than simple imports... But overall it does not matter, its just my kind of fetish :D
There was a problem hiding this comment.
So, I suppose, this is a clash of two fetishes :-( And I am the evil admin of this repo, so please obey, muhahaha! ;-)
|
Also, it would be awesome if you could mention this error and the API limitation right in the README. Thanks! |
|
I scanned through issues and I see I discussed the rate limiting problem already in #4 (comment). May be useful for further thoughts. |
| @@ -50,8 +50,11 @@ Listing latest transactions: | |||
| >>> client.last(from_date='2013-03-01') # sets cursor to given date and returns following transactions | |||
| ``` | |||
|
|
|||
| For further information [read code](https://github.com/honzajavorek/fiobank/blob/master/fiobank.py). | |||
| ## Conflict error | |||
| [Fio api documentation](http://www.fio.cz/docs/cz/API_Bankovnictvi.pdf) (Section 8.2) states that a single token should be used only once per 30s. Otherwise a HTTP conflict will be returned and `Fiobank.ThrottlingError` will be raised. | |||
|
@Visgean Why this got closed? I know I didn't get to Fiobank recently, but I'm planning to dedicate it at least one evening to merge PRs, polish the code and release a new version. |
|
I have closed all my PR that were inactive for a year. I will reopen this one because you seem to be interested. |
|
Thanks! |
No description provided.