Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added (l/r)angle to ultisnips,added mathfonts to snippets #589

Merged
merged 1 commit into from
Jun 8, 2015
Merged

added (l/r)angle to ultisnips,added mathfonts to snippets #589

merged 1 commit into from
Jun 8, 2015

Conversation

kevinywlui
Copy link
Contributor

Added some snippets that I've been using often.

(First time using git in a nontrivial manner, hope I'm doing this right.)

@lpil
Copy link
Contributor

lpil commented Jun 5, 2015

Hello! Thanks for your contribution :)

What made you decide to add those ones to the ultisnips format, and those ones to the snipmate format?

@kevinywlui
Copy link
Contributor Author

I looked through both the ultisnips formatted file and snipmate formatted file and placed these snippets near similar ones.

To be honest, it's still unclear to me when to use each format. I've read through #363. But I'm not sure what the final decision is. It seems like most of the .tex snippets can be implemented in the snipmate format.

@lpil
Copy link
Contributor

lpil commented Jun 7, 2015

Best to stick everything in the snipmate format in my opinion :)

@kevinywlui
Copy link
Contributor Author

Updated. Also fixed a conflict with 'eq' snippet between snipmate and ultisnips.

@lpil
Copy link
Contributor

lpil commented Jun 8, 2015

Great. Could you indent with tabs rather than spaces please? :)

@kevinywlui
Copy link
Contributor Author

Fixed!

@lpil
Copy link
Contributor

lpil commented Jun 8, 2015

Thanks! :D

lpil added a commit that referenced this pull request Jun 8, 2015
added (l/r)angle to ultisnips,added mathfonts to snippets
@lpil lpil merged commit 69c9181 into honza:master Jun 8, 2015
@kevinywlui
Copy link
Contributor Author

Thanks for all the help! I really appreciate it!

@lpil
Copy link
Contributor

lpil commented Jun 8, 2015

Not at all, thank you for contributing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants