Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated dockerfile to allow building without local repo, changed couchdb to have flexible hostname #7

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

NewlineDotBlog
Copy link

Hi,

When I tried to install bbrf on my local server I ran into some issues installing it all through portainer. Despite cloning the entire repository to another location on my server, the set up would refuse to work. After some tinkering it seems the following two issues fixed in this pull request caused the issues.

For whatever reason, docker refuses to run docker-entrypoint.sh (due to permission issues) if it is mapped as volume in the docker compose file. After some tinkering, it seems that replacing the COPY commands in the dockerfile to ADD commands which simply retrieve the files from the github repo seems to work just fine.

Secondly, allowing to change the hostname of couchdb helps in situations where there are several other instances of couchdb running in the same network. Since the hostname was hardcoded in the bbrf-init.sh file, I updated this to instead use a new local environment variable COUCHDB_HOSTNAME instead. This seems to work and allow the server to start without a local repo. (save for a few locally copied config files)

Apologies if this is a bad PR, there is a first time for everything. If you'd like to see things changed let me know.

@honoki
Copy link
Owner

honoki commented Nov 4, 2021

Hi @NewlineDotBlog - thanks for this PR. I like the changes that remove the requirements for a local repo and would like to merge those in.

I'm not so sure about the hostname variable; as it stands it seems like a user would need to edit the hostname in 3 places still: the service hostname, the COUCHDB_HOSTNAME variable, and the depends_on. For that reason, it doesn't seem easier than manually changing them. If you can find a way to combine those all together, I would welcome that change, otherwise can you please make a new PR that only incorporates the dockerfile changes?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants