Updated dockerfile to allow building without local repo, changed couchdb to have flexible hostname #7
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
When I tried to install bbrf on my local server I ran into some issues installing it all through portainer. Despite cloning the entire repository to another location on my server, the set up would refuse to work. After some tinkering it seems the following two issues fixed in this pull request caused the issues.
For whatever reason, docker refuses to run
docker-entrypoint.sh
(due to permission issues) if it is mapped as volume in the docker compose file. After some tinkering, it seems that replacing theCOPY
commands in the dockerfile toADD
commands which simply retrieve the files from the github repo seems to work just fine.Secondly, allowing to change the hostname of couchdb helps in situations where there are several other instances of couchdb running in the same network. Since the hostname was hardcoded in the
bbrf-init.sh
file, I updated this to instead use a new local environment variableCOUCHDB_HOSTNAME
instead. This seems to work and allow the server to start without a local repo. (save for a few locally copied config files)Apologies if this is a bad PR, there is a first time for everything. If you'd like to see things changed let me know.