Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replaces TypeCompiler with Value #90

Merged
merged 2 commits into from
Jul 15, 2023
Merged

Replaces TypeCompiler with Value #90

merged 2 commits into from
Jul 15, 2023

Conversation

NotAmaan
Copy link
Contributor

@NotAmaan NotAmaan commented Jun 2, 2023

Cloudflare worker throws an EvalError when using TypeCompiler.Compile(schema).Check(data)

Uncaught Error: EvalError: Code generation from strings disallowed for this context at index.js:5110:45 in Compile

sinclairzx81/typebox#253

Cloudflare worker throws an EvalError when using TypeCompiler.Compile(schema).Check(data)
@changeset-bot
Copy link

changeset-bot bot commented Jun 2, 2023

🦋 Changeset detected

Latest commit: cf3bd0f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@hono/typebox-validator Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@yusukebe
Copy link
Member

yusukebe commented Jun 6, 2023

Hi @NotAmaan !

Thank your for creating the PR. I'd like to merge it. So, please yarn changeset to create the changset, write it, add&commit&push it.

@yusukebe
Copy link
Member

Hi @NotAmaan

Apologies for the delay. I'm going to merge this now.

@yusukebe yusukebe merged commit 65ed112 into honojs:main Jul 15, 2023
@github-actions github-actions bot mentioned this pull request Jul 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants