fix(hono-base): remove .matchRoute and reduce bundle size
#3595
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3595 +/- ##
==========================================
- Coverage 94.71% 94.71% -0.01%
==========================================
Files 158 158
Lines 9557 9552 -5
Branches 2826 2775 -51
==========================================
- Hits 9052 9047 -5
Misses 505 505 ☔ View full report in Codecov by Sentry. |
|
You are right! We can remove it. Thanks. |
TinsFox
pushed a commit
to TinsFox/hono
that referenced
this pull request
Nov 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
.matchRouteis a private method that is only called from one place and does not wrap a complex process, so I think it can be removed.This will reduce the bundle size.
The author should do the following, if applicable
bun run format:fix && bun run lint:fixto format the code