-
-
Notifications
You must be signed in to change notification settings - Fork 598
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(devcontainer): remove unknown flag on docker-compose #3582
Conversation
What do you think about this? I think that there is little security risk with this change. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3582 +/- ##
=======================================
Coverage 94.71% 94.71%
=======================================
Files 158 158
Lines 9535 9535
Branches 2807 2807
=======================================
Hits 9031 9031
Misses 504 504 ☔ View full report in Codecov by Sentry. |
Oh sorry about that. I had not tested the new config with workspaces. The additional config values are coming straight from the devcontainer docs: https://code.visualstudio.com/remote/advancedcontainers/docker-options#_podman |
I'm not familiar with the dev container, but it looks good. @EdamAme-x Is this okay to merge? |
I think it will be fine! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
@EdamAme-x Thanks! Let's go. |
I tried out your branch locally with Podman and I can still build the container image and run all tests. Seems to work with Podman as well! |
Thanks for testing it. |
Closes #3581
The author should do the following, if applicable
bun run format:fix && bun run lint:fix
to format the code