Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(devcontainer): remove unknown flag on docker-compose #3582

Merged
merged 1 commit into from
Oct 29, 2024

Conversation

EdamAme-x
Copy link
Contributor

@EdamAme-x EdamAme-x commented Oct 29, 2024

Closes #3581

The author should do the following, if applicable

  • Add tests
  • Run tests
  • bun run format:fix && bun run lint:fix to format the code
  • Add TSDoc/JSDoc to document the code

@EdamAme-x
Copy link
Contributor Author

EdamAme-x commented Oct 29, 2024

What do you think about this?
@marcomuser

I think that there is little security risk with this change.

Copy link

codecov bot commented Oct 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.71%. Comparing base (e7732a5) to head (0afc681).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3582   +/-   ##
=======================================
  Coverage   94.71%   94.71%           
=======================================
  Files         158      158           
  Lines        9535     9535           
  Branches     2807     2807           
=======================================
  Hits         9031     9031           
  Misses        504      504           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@marcomuser
Copy link
Contributor

Oh sorry about that. I had not tested the new config with workspaces. The additional config values are coming straight from the devcontainer docs: https://code.visualstudio.com/remote/advancedcontainers/docker-options#_podman

@EdamAme-x
Copy link
Contributor Author

Thanks for your reply.
This change made it work.
image

@yusukebe
Copy link
Member

I'm not familiar with the dev container, but it looks good. @EdamAme-x Is this okay to merge?

@EdamAme-x
Copy link
Contributor Author

I think it will be fine!

Copy link
Member

@yusukebe yusukebe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@yusukebe
Copy link
Member

@EdamAme-x Thanks! Let's go.

@yusukebe yusukebe merged commit 0e0b473 into honojs:main Oct 29, 2024
16 checks passed
@marcomuser
Copy link
Contributor

I tried out your branch locally with Podman and I can still build the container image and run all tests. Seems to work with Podman as well!

@EdamAme-x
Copy link
Contributor Author

Thanks for testing it.

TinsFox pushed a commit to TinsFox/hono that referenced this pull request Nov 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

devcontainer build error on codespaces
3 participants