Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(vercel): remove requestContext #3549

Merged
merged 1 commit into from
Oct 23, 2024
Merged

Conversation

yusukebe
Copy link
Member

@yusukebe yusukebe commented Oct 23, 2024

Fixes #3548

The requestContext, which is used in the second argument of the handler, is no longer needed. Because the current version of Next.js passes only the values of params. But, you can get the params value from c.req.param().

Ref: https://nextjs.org/docs/app/api-reference/file-conventions/route#context-optional
Ref: https://nextjs.org/docs/app/building-your-application/routing/dynamic-routes#typescript

The author should do the following, if applicable

  • Add tests
  • Run tests
  • bun run format:fix && bun run lint:fix to format the code
  • Add TSDoc/JSDoc to document the code

Copy link

codecov bot commented Oct 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.29%. Comparing base (631c001) to head (c7022aa).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3549   +/-   ##
=======================================
  Coverage   94.29%   94.29%           
=======================================
  Files         157      157           
  Lines        9499     9499           
  Branches     2885     2852   -33     
=======================================
  Hits         8957     8957           
  Misses        542      542           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yusukebe yusukebe merged commit 7735f2f into main Oct 23, 2024
16 checks passed
@yusukebe yusukebe deleted the fix/vercel-remove-request-context branch October 23, 2024 00:36
TinsFox pushed a commit to TinsFox/hono that referenced this pull request Oct 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Next.js 15: Type "FetchEventLike" is not a valid type for the function's second argument.
1 participant