feat(jwt): Support custom secret keys for signing JWTs #3546
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Expanded key type check to include 'secret' for JWT signing. This aligns importPrivateKey method with importPublicKey method for handling "secret" type keys. - Added a test case to sign, verify, and decode using a custom secret, ensuring the correct flow and error handling with mismatched keys.
kaandok
changed the title
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3546 +/- ##
==========================================
- Coverage 94.29% 94.27% -0.02%
==========================================
Files 157 157
Lines 9499 9501 +2
Branches 2761 2744 -17
==========================================
Hits 8957 8957
- Misses 542 544 +2 ☔ View full report in Codecov by Sentry. |
yusukebe
reviewed
Oct 23, 2024
|
Hi @kaandok Nice PR! One thing I've left it as a comment. |
|
Updated, thank you! |
|
@kaandok Thank you for the quick fix. Merging now! |
TinsFox
pushed a commit
to TinsFox/hono
that referenced
this pull request
Oct 28, 2024
* Support custom secret keys for signing JWTs - Expanded key type check to include 'secret' for JWT signing. This aligns importPrivateKey method with importPublicKey method for handling "secret" type keys. - Added a test case to sign, verify, and decode using a custom secret, ensuring the correct flow and error handling with mismatched keys. * update comment for rejected private key imports
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Expanded key type check to include 'secret' for JWT signing. This aligns importPrivateKey method with importPublicKey method for handling "secret" type keys.
Added a test case to sign, verify, and decode using a custom secret, ensuring the correct flow and error handling with mismatched keys.
The author should do the following, if applicable
bun run format:fix && bun run lint:fixto format the code