Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: use Deno v2 for a test running for deno #3509

Merged
merged 2 commits into from
Oct 13, 2024
Merged

Conversation

nakasyou
Copy link
Contributor

Deno 2 has been released, so I changed a CI.

The author should do the following, if applicable

  • Add tests
  • Run tests
  • bun run format:fix && bun run lint:fix to format the code
  • Add TSDoc/JSDoc to document the code

@nakasyou nakasyou marked this pull request as draft October 12, 2024 08:27
@nakasyou nakasyou marked this pull request as ready for review October 12, 2024 08:27
Copy link

codecov bot commented Oct 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.58%. Comparing base (9986b47) to head (c5be238).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3509   +/-   ##
=======================================
  Coverage   95.58%   95.58%           
=======================================
  Files         155      155           
  Lines        9357     9357           
  Branches     2749     2757    +8     
=======================================
  Hits         8944     8944           
  Misses        413      413           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

.github/workflows/ci.yml Outdated Show resolved Hide resolved
@yusukebe
Copy link
Member

Hi @nakasyou

Thank you! I've left a comment.

@nakasyou
Copy link
Contributor Author

I have a question. Deno 2.0 has breaking changes. Should I test both 1.x and 2.0?

@yusukebe
Copy link
Member

@nakasyou

Thank you for the fix.

I have a question. Deno 2.0 has breaking changes. Should I test both 1.x and 2.0?

Hmm. I think it's unnecessary. It's enough to test the latest major version, and if there are problems, we can say please try to use the latest Deno.

@nakasyou What is your thought?

@nakasyou
Copy link
Contributor Author

@yusukebe

It's enough to test the latest major version

I agree. Also, Deno's LTS is shorter than Node.js, so there is no need to test multiple versions.

@yusukebe
Copy link
Member

@nakasyou

Okay. I'll merge this now. Thanks!

@yusukebe yusukebe changed the title chore: use Deno v2 for a test running for deno ci: use Deno v2 for a test running for deno Oct 13, 2024
@yusukebe yusukebe merged commit bd9effe into honojs:main Oct 13, 2024
16 checks passed
@nakasyou nakasyou deleted the chore/deno2 branch October 13, 2024 07:48
TinsFox pushed a commit to TinsFox/hono that referenced this pull request Oct 28, 2024
* chore: use Deno v2 for a test running for deno

* use denoland/setup-deno@v2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants