-
-
Notifications
You must be signed in to change notification settings - Fork 655
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(request): Make request.ts available throught JSR for frameworks that need to instantiate HonoRequest #3425
Conversation
Hey @Sorikairox Thank you for the PR! The |
Thanks for your answer ! The context is for our framework Danet (https://github.com/savory/Danet). For the past 12 months or so until last week, we were using Hono's deno.land/x/ version, where everything was accessible. To keep it simple, in order to allow our internal logic and our users to use the same code with either HTTP request or Websocket message, we instantiate a HonoRequest for the latter. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3425 +/- ##
=======================================
Coverage 95.77% 95.77%
=======================================
Files 155 155
Lines 9310 9310
Branches 2725 2757 +32
=======================================
Hits 8917 8917
Misses 393 393 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Thank you for your explanation! I understood well. I'll merge this into |
…that need to instantiate HonoRequest (honojs#3425) * Update jsr.json * Update jsr.json
The author should do the following, if applicable
bun run format:fix && bun run lint:fix
to format the code