Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deno): use the latest jsr libraries for testing #3375

Merged
merged 1 commit into from
Sep 4, 2024

Conversation

ryuapp
Copy link
Contributor

@ryuapp ryuapp commented Sep 3, 2024

Update libraries for writing tests in #3367. Also, this PR removes unnecessary code.

The author should do the following, if applicable

  • Add tests
  • Run tests
  • bun run format:fix && bun run lint:fix to format the code
  • Add TSDoc/JSDoc to document the code

Copy link

codecov bot commented Sep 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.77%. Comparing base (3500404) to head (699513b).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3375   +/-   ##
=======================================
  Coverage   95.77%   95.77%           
=======================================
  Files         152      152           
  Lines        9187     9187           
  Branches     2818     2749   -69     
=======================================
  Hits         8799     8799           
  Misses        388      388           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@yusukebe yusukebe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@yusukebe
Copy link
Member

yusukebe commented Sep 4, 2024

@ryuapp

We needed to do this. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants