Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(jsx): improve form attribute types #3330

Merged
merged 1 commit into from
Aug 29, 2024

Conversation

ssssota
Copy link
Contributor

@ssssota ssssota commented Aug 28, 2024

Improve form attribute types (accept-charset, autocomplete, enctype and method).
button and input tag attributes are also updated (formenctype and formmethod).

image

The author should do the following, if applicable

  • Add tests
  • Run tests
  • bun run format:fix && bun run lint:fix to format the code
  • Add TSDoc/JSDoc to document the code

Copy link

codecov bot commented Aug 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.32%. Comparing base (bc2b7cf) to head (b0f0e22).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3330   +/-   ##
=======================================
  Coverage   96.32%   96.32%           
=======================================
  Files         151      151           
  Lines       15418    15418           
  Branches     2714     2779   +65     
=======================================
  Hits        14852    14852           
  Misses        566      566           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@yusukebe yusukebe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@yusukebe
Copy link
Member

@ssssota

Thank you for the PR! I didn't know dialog for the value of the form method!

I'll merge it now.

@yusukebe yusukebe merged commit e449c95 into honojs:main Aug 29, 2024
14 checks passed
@ssssota ssssota deleted the feat/improve-form-attribute-types branch August 29, 2024 08:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants