-
-
Notifications
You must be signed in to change notification settings - Fork 655
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(compress): improve compress middleware #3317
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for making the pull request! I think this pull request will greatly improve the "compress" middleware.
I've made some comments and hoped you could check them.
Thank you too :) Pushed the changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3317 +/- ##
=======================================
Coverage 96.31% 96.31%
=======================================
Files 151 151
Lines 15368 15401 +33
Branches 2693 2696 +3
=======================================
+ Hits 14801 14834 +33
Misses 567 567 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Hi @nitedani Awesome improvement! I'll merge this into the main and include it in the next patch release. Thank you! |
Improvements:
Fixes:
compress
middleware gzips images #3262Add tests
Run tests
bun run format:fix && bun run lint:fix
to format the codeAdd TSDoc/JSDoc to document the code