Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(types): remove any and fix types of adapter/deno #3291

Merged
merged 4 commits into from
Oct 30, 2024

Conversation

EdamAme-x
Copy link
Contributor

@EdamAme-x EdamAme-x commented Aug 18, 2024

The author should do the following, if applicable

  • Add tests
  • Run tests
  • bun run format:fix && bun run lint:fix to format the code
  • Add TSDoc/JSDoc to document the code

Copy link

codecov bot commented Aug 18, 2024

Codecov Report

Attention: Patch coverage is 33.33333% with 2 lines in your changes missing coverage. Please review.

Project coverage is 94.71%. Comparing base (3164326) to head (ac51ea3).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
src/adapter/deno/serve-static.ts 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3291      +/-   ##
==========================================
- Coverage   94.72%   94.71%   -0.01%     
==========================================
  Files         158      158              
  Lines        9553     9554       +1     
  Branches     2815     2814       -1     
==========================================
  Hits         9049     9049              
- Misses        504      505       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@EdamAme-x EdamAme-x changed the title fix(types): remove any and fix types of adapter/deno fix(types): remove any and fix types of adapter/deno Aug 25, 2024
@EdamAme-x
Copy link
Contributor Author

Hi @yusukebe
Could you review this?

Copy link
Member

@yusukebe yusukebe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@EdamAme-x
Copy link
Contributor Author

All checks passed

@yusukebe
Copy link
Member

Okay! Let's go!

@yusukebe yusukebe merged commit caeecf9 into honojs:main Oct 30, 2024
16 checks passed
TinsFox pushed a commit to TinsFox/hono that referenced this pull request Nov 11, 2024
* fix(types): remove any and fix types of adapter/deno

* fix some errors

* refactor jsdoc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants