Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(jsx): fix draggable type to accept boolean #3253

Merged
merged 1 commit into from
Aug 10, 2024

Conversation

yasuaki640
Copy link
Contributor

React accepts a boolean for the draggable attribute, so I adapted the behavior.
Incidentally, other Boolianish values also render a 'true' or 'false' string when they receive a boolean, so this type definition should be less confusing to the user.

An example of the code is as follows

  it('test draggable', () => {
    const template = <div draggable={true}>draggable</div>
    expect(template.toString()).toBe('<div draggable="true">draggable</div>')
  })

  // other booleanish value
  it('test spellcheck', () => {
    const template = <div spellcheck={true}>spellcheck</div>
    expect(template.toString()).toBe('<div spellcheck="true">spellcheck</div>')
  })

The author should do the following, if applicable

  • Add tests
  • Run tests
  • bun run format:fix && bun run lint:fix to format the code
  • Add TSDoc/JSDoc to document the code

@yasuaki640 yasuaki640 changed the title fix draggable type to accept boolean fix(jsx): fix draggable type to accept boolean Aug 9, 2024
Copy link

codecov bot commented Aug 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.23%. Comparing base (7cd0248) to head (f11067a).

Additional details and impacted files
@@           Coverage Diff            @@
##             main    #3253    +/-   ##
========================================
  Coverage   96.23%   96.23%            
========================================
  Files         151      151            
  Lines       15197    15197            
  Branches     2643     2759   +116     
========================================
  Hits        14625    14625            
  Misses        572      572            

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@yusukebe yusukebe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@yusukebe
Copy link
Member

@yasuaki640

Thanks! Good improvement. I'll merge this now.

@yusukebe yusukebe merged commit 8ba0227 into honojs:main Aug 10, 2024
14 checks passed
adamnolte referenced this pull request in autoblocksai/cli Aug 12, 2024
[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [hono](https://hono.dev/) ([source](https://togithub.com/honojs/hono))
| [`4.5.4` ->
`4.5.5`](https://renovatebot.com/diffs/npm/hono/4.5.4/4.5.5) |
[![age](https://developer.mend.io/api/mc/badges/age/npm/hono/4.5.5?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/hono/4.5.5?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/hono/4.5.4/4.5.5?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/hono/4.5.4/4.5.5?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|

---

### Release Notes

<details>
<summary>honojs/hono (hono)</summary>

### [`v4.5.5`](https://togithub.com/honojs/hono/releases/tag/v4.5.5)

[Compare
Source](https://togithub.com/honojs/hono/compare/v4.5.4...v4.5.5)

#### What's Changed

- fix(jsx): allow null, undefined, and boolean to be returned from
function component by [@&#8203;usualoma](https://togithub.com/usualoma)
in
[https://github.com/honojs/hono/pull/3241](https://togithub.com/honojs/hono/pull/3241)
- feat(context): Add types for `c.header` by
[@&#8203;nakasyou](https://togithub.com/nakasyou) in
[https://github.com/honojs/hono/pull/3221](https://togithub.com/honojs/hono/pull/3221)
- fix(jsx): fix draggable type to accept boolean by
[@&#8203;yasuaki640](https://togithub.com/yasuaki640) in
[https://github.com/honojs/hono/pull/3253](https://togithub.com/honojs/hono/pull/3253)
- feat(context): add Context-Type types to `c.header` by
[@&#8203;nakasyou](https://togithub.com/nakasyou) in
[https://github.com/honojs/hono/pull/3255](https://togithub.com/honojs/hono/pull/3255)
- fix(serve-static): supports directory contains `.` and not end `/` by
[@&#8203;yusukebe](https://togithub.com/yusukebe) in
[https://github.com/honojs/hono/pull/3256](https://togithub.com/honojs/hono/pull/3256)

**Full Changelog**:
honojs/hono@v4.5.4...v4.5.5

</details>

---

### Configuration

📅 **Schedule**: Branch creation - "before 4am on Monday" in timezone
America/Chicago, Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR was generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View the
[repository job log](https://developer.mend.io/github/autoblocksai/cli).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOC4yMC4xIiwidXBkYXRlZEluVmVyIjoiMzguMjAuMSIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOltdfQ==-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants