Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use correct return type for c.html depending on input #2973

Merged
merged 1 commit into from
Jun 15, 2024

Conversation

asmadsen
Copy link
Contributor

I had some issues with using c.html with a non-promise body that had the return-type Response | Promise<Response>. This should use correct return-type depending on the input.

The author should do the following, if applicable

  • bun run format:fix && bun run lint:fix to format the code

@yusukebe
Copy link
Member

Hi @asmadsen Thank you for the PR.

Hey @usualoma Question. Can we think, if the first argument of c.html() is Promise, the return type is always Promise<Response>?

@usualoma
Copy link
Member

Hi @asmadsen Thank you!

@yusukebe Yes, a Promise is returned whenever a Promise is given!

@asmadsen
Copy link
Contributor Author

@yusukebe As @usualoma answered, if the first argument is Promise the return type is always Promise<Response>.

I saw there was a type error in the tests, so I fixed that. As well as added explicit type declarations so it would give an type error if the expected type is not returned.

Copy link

codecov bot commented Jun 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.73%. Comparing base (614dff0) to head (66f588f).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2973   +/-   ##
=======================================
  Coverage   94.73%   94.73%           
=======================================
  Files         136      136           
  Lines       13335    13339    +4     
  Branches     2251     2229   -22     
=======================================
+ Hits        12633    12637    +4     
  Misses        702      702           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

src/context.test.ts Show resolved Hide resolved
src/context.test.ts Show resolved Hide resolved
Copy link
Member

@yusukebe yusukebe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@yusukebe
Copy link
Member

@asmadsen

Thank you for your contribution! I'll merge this now.

@yusukebe yusukebe merged commit e6bfb45 into honojs:main Jun 15, 2024
14 checks passed
nicolewhite referenced this pull request in autoblocksai/cli Jun 24, 2024
[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [hono](https://hono.dev/) ([source](https://togithub.com/honojs/hono))
| [`4.4.4` ->
`4.4.7`](https://renovatebot.com/diffs/npm/hono/4.4.4/4.4.7) |
[![age](https://developer.mend.io/api/mc/badges/age/npm/hono/4.4.7?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/hono/4.4.7?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/hono/4.4.4/4.4.7?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/hono/4.4.4/4.4.7?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|

---

### Release Notes

<details>
<summary>honojs/hono (hono)</summary>

### [`v4.4.7`](https://togithub.com/honojs/hono/releases/tag/v4.4.7)

[Compare
Source](https://togithub.com/honojs/hono/compare/v4.4.6...v4.4.7)

#### What's Changed

- use correct return type for c.html depending on input by
[@&#8203;asmadsen](https://togithub.com/asmadsen) in
[https://github.com/honojs/hono/pull/2973](https://togithub.com/honojs/hono/pull/2973)
- test: test uncovered return statement by
[@&#8203;yasuaki640](https://togithub.com/yasuaki640) in
[https://github.com/honojs/hono/pull/2985](https://togithub.com/honojs/hono/pull/2985)
- test: Update request.test.ts to remove duplicate checks by
[@&#8203;JoaquimLey](https://togithub.com/JoaquimLey) in
[https://github.com/honojs/hono/pull/2984](https://togithub.com/honojs/hono/pull/2984)
- fix(types): env variables override ContextVariableMap by
[@&#8203;KaelWD](https://togithub.com/KaelWD) in
[https://github.com/honojs/hono/pull/2987](https://togithub.com/honojs/hono/pull/2987)

#### New Contributors

- [@&#8203;asmadsen](https://togithub.com/asmadsen) made their first
contribution in
[https://github.com/honojs/hono/pull/2973](https://togithub.com/honojs/hono/pull/2973)
- [@&#8203;JoaquimLey](https://togithub.com/JoaquimLey) made their first
contribution in
[https://github.com/honojs/hono/pull/2984](https://togithub.com/honojs/hono/pull/2984)
- [@&#8203;KaelWD](https://togithub.com/KaelWD) made their first
contribution in
[https://github.com/honojs/hono/pull/2987](https://togithub.com/honojs/hono/pull/2987)

**Full Changelog**:
honojs/hono@v4.4.6...v4.4.7

### [`v4.4.6`](https://togithub.com/honojs/hono/releases/tag/v4.4.6)

[Compare
Source](https://togithub.com/honojs/hono/compare/v4.4.5...v4.4.6)

##### What's Changed

- fix(aws-lambda): handle multiple cookies in streaming responses by
[@&#8203;KnisterPeter](https://togithub.com/KnisterPeter) in
[https://github.com/honojs/hono/pull/2926](https://togithub.com/honojs/hono/pull/2926)

**Full Changelog**:
honojs/hono@v4.4.5...v4.4.6

### [`v4.4.5`](https://togithub.com/honojs/hono/releases/tag/v4.4.5)

[Compare
Source](https://togithub.com/honojs/hono/compare/v4.4.4...v4.4.5)

##### What's Changed

- fix(cors): allow custom vary header by
[@&#8203;fzn0x](https://togithub.com/fzn0x) in
[https://github.com/honojs/hono/pull/2934](https://togithub.com/honojs/hono/pull/2934)
- fix(jsx): rename `Hono` to `JSX` and export `JSX` namespace by
[@&#8203;yusukebe](https://togithub.com/yusukebe) in
[https://github.com/honojs/hono/pull/2937](https://togithub.com/honojs/hono/pull/2937)
- refactor(hono-base): make 2nd arg of `app.route()` required by
[@&#8203;yusukebe](https://togithub.com/yusukebe) in
[https://github.com/honojs/hono/pull/2945](https://togithub.com/honojs/hono/pull/2945)
- refactor(hono-base): don't check 1st argument of `app.on()` by
[@&#8203;yusukebe](https://togithub.com/yusukebe) in
[https://github.com/honojs/hono/pull/2946](https://togithub.com/honojs/hono/pull/2946)
- refactor(context): remove unnecessary initialization add add tests for
Context by [@&#8203;yusukebe](https://togithub.com/yusukebe) in
[https://github.com/honojs/hono/pull/2949](https://togithub.com/honojs/hono/pull/2949)
- test(hono-base): add tests for covering 100% by
[@&#8203;yusukebe](https://togithub.com/yusukebe) in
[https://github.com/honojs/hono/pull/2952](https://togithub.com/honojs/hono/pull/2952)
- fix(context): default JSONRespond and TextRespond StatusCode generic
arg by [@&#8203;EdamAme-x](https://togithub.com/EdamAme-x) in
[https://github.com/honojs/hono/pull/2954](https://togithub.com/honojs/hono/pull/2954)
- refactor(request): shorten `parseBody` and remove unnecessary check by
[@&#8203;yusukebe](https://togithub.com/yusukebe) in
[https://github.com/honojs/hono/pull/2947](https://togithub.com/honojs/hono/pull/2947)
- refactor(jsx): reduce code size and improve maintainability by
[@&#8203;usualoma](https://togithub.com/usualoma) in
[https://github.com/honojs/hono/pull/2956](https://togithub.com/honojs/hono/pull/2956)

**Full Changelog**:
honojs/hono@v4.4.4...v4.4.5

</details>

---

### Configuration

📅 **Schedule**: Branch creation - "before 4am on Monday" in timezone
America/Chicago, Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://developer.mend.io/github/autoblocksai/cli).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4zOTMuMCIsInVwZGF0ZWRJblZlciI6IjM3LjQxMC4xIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6W119-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants