refactor(hono-base): don't check 1st argument of app.on()
#2946
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yusukebe
changed the title
app.on()
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2946 +/- ##
==========================================
+ Coverage 94.44% 94.45% +0.01%
==========================================
Files 136 136
Lines 13349 13346 -3
Branches 2284 2254 -30
==========================================
- Hits 12607 12606 -1
+ Misses 742 740 -2 ☔ View full report in Codecov by Sentry. |
|
Hey @usualoma , what do you think of this? I think removing the lines is not a problem. |
|
@yusukebe Empty strings do not make sense and should not be checked 👍 |
|
@usualoma Thanks! |
nicolewhite
referenced
this pull request
in autoblocksai/cli
Jun 24, 2024
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [hono](https://hono.dev/) ([source](https://togithub.com/honojs/hono)) | [`4.4.4` -> `4.4.7`](https://renovatebot.com/diffs/npm/hono/4.4.4/4.4.7) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>honojs/hono (hono)</summary> ### [`v4.4.7`](https://togithub.com/honojs/hono/releases/tag/v4.4.7) [Compare Source](https://togithub.com/honojs/hono/compare/v4.4.6...v4.4.7) #### What's Changed - use correct return type for c.html depending on input by [@​asmadsen](https://togithub.com/asmadsen) in [https://github.com/honojs/hono/pull/2973](https://togithub.com/honojs/hono/pull/2973) - test: test uncovered return statement by [@​yasuaki640](https://togithub.com/yasuaki640) in [https://github.com/honojs/hono/pull/2985](https://togithub.com/honojs/hono/pull/2985) - test: Update request.test.ts to remove duplicate checks by [@​JoaquimLey](https://togithub.com/JoaquimLey) in [https://github.com/honojs/hono/pull/2984](https://togithub.com/honojs/hono/pull/2984) - fix(types): env variables override ContextVariableMap by [@​KaelWD](https://togithub.com/KaelWD) in [https://github.com/honojs/hono/pull/2987](https://togithub.com/honojs/hono/pull/2987) #### New Contributors - [@​asmadsen](https://togithub.com/asmadsen) made their first contribution in [https://github.com/honojs/hono/pull/2973](https://togithub.com/honojs/hono/pull/2973) - [@​JoaquimLey](https://togithub.com/JoaquimLey) made their first contribution in [https://github.com/honojs/hono/pull/2984](https://togithub.com/honojs/hono/pull/2984) - [@​KaelWD](https://togithub.com/KaelWD) made their first contribution in [https://github.com/honojs/hono/pull/2987](https://togithub.com/honojs/hono/pull/2987) **Full Changelog**: honojs/hono@v4.4.6...v4.4.7 ### [`v4.4.6`](https://togithub.com/honojs/hono/releases/tag/v4.4.6) [Compare Source](https://togithub.com/honojs/hono/compare/v4.4.5...v4.4.6) ##### What's Changed - fix(aws-lambda): handle multiple cookies in streaming responses by [@​KnisterPeter](https://togithub.com/KnisterPeter) in [https://github.com/honojs/hono/pull/2926](https://togithub.com/honojs/hono/pull/2926) **Full Changelog**: honojs/hono@v4.4.5...v4.4.6 ### [`v4.4.5`](https://togithub.com/honojs/hono/releases/tag/v4.4.5) [Compare Source](https://togithub.com/honojs/hono/compare/v4.4.4...v4.4.5) ##### What's Changed - fix(cors): allow custom vary header by [@​fzn0x](https://togithub.com/fzn0x) in [https://github.com/honojs/hono/pull/2934](https://togithub.com/honojs/hono/pull/2934) - fix(jsx): rename `Hono` to `JSX` and export `JSX` namespace by [@​yusukebe](https://togithub.com/yusukebe) in [https://github.com/honojs/hono/pull/2937](https://togithub.com/honojs/hono/pull/2937) - refactor(hono-base): make 2nd arg of `app.route()` required by [@​yusukebe](https://togithub.com/yusukebe) in [https://github.com/honojs/hono/pull/2945](https://togithub.com/honojs/hono/pull/2945) - refactor(hono-base): don't check 1st argument of `app.on()` by [@​yusukebe](https://togithub.com/yusukebe) in [https://github.com/honojs/hono/pull/2946](https://togithub.com/honojs/hono/pull/2946) - refactor(context): remove unnecessary initialization add add tests for Context by [@​yusukebe](https://togithub.com/yusukebe) in [https://github.com/honojs/hono/pull/2949](https://togithub.com/honojs/hono/pull/2949) - test(hono-base): add tests for covering 100% by [@​yusukebe](https://togithub.com/yusukebe) in [https://github.com/honojs/hono/pull/2952](https://togithub.com/honojs/hono/pull/2952) - fix(context): default JSONRespond and TextRespond StatusCode generic arg by [@​EdamAme-x](https://togithub.com/EdamAme-x) in [https://github.com/honojs/hono/pull/2954](https://togithub.com/honojs/hono/pull/2954) - refactor(request): shorten `parseBody` and remove unnecessary check by [@​yusukebe](https://togithub.com/yusukebe) in [https://github.com/honojs/hono/pull/2947](https://togithub.com/honojs/hono/pull/2947) - refactor(jsx): reduce code size and improve maintainability by [@​usualoma](https://togithub.com/usualoma) in [https://github.com/honojs/hono/pull/2956](https://togithub.com/honojs/hono/pull/2956) **Full Changelog**: honojs/hono@v4.4.4...v4.4.5 </details> --- ### Configuration 📅 **Schedule**: Branch creation - "before 4am on Monday" in timezone America/Chicago, Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/autoblocksai/cli). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4zOTMuMCIsInVwZGF0ZWRJblZlciI6IjM3LjQxMC4xIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6W119--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
](https://renovatebot.com){kind=link}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes checking the actual value of the first argument on
app.on(). I think it is ok not to check because the argument is typed as required. And if the coming actual value is undefined, it will be checked in the initialization phase, so it's no problem just throwing an error.The author should do the following, if applicable
bun run format:fix && bun run lint:fixto format the code