fix(filepath): allow suffix includes - and _

[yusukebe]

Fixes #2251 (comment)

The author should do the following, if applicable

• Add tests
• Run tests
• bun run format:fix && bun run lint:fix to format the code
• Add TSDoc/JSDoc to document the code

[yusukebe]

@usualoma Can you review this?

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.10%. Comparing base (0d851b6) to head (805c5eb).

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #2910   +/-   ##
=======================================
  Coverage   94.10%   94.10%           
=======================================
  Files         136      136           
  Lines       13369    13369           
  Branches     2266     2240   -26     
=======================================
  Hits        12581    12581           
  Misses        788      788           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[usualoma]

Hi @yusukebe

As I understand it, the problem is that console.warn() is called when the file does not exist, in Deno.

It is not called console.warn() in bun.
https://github.com/usualoma/hono/blob/121746b8727d740cf6e36433ae55721f74b78353/src/adapter/bun/serve-static.ts#L13-L14

node-server checks for the existence of the file first.
https://github.com/usualoma/node-server/blob/a0be98b95ed5221d96c988565e5f5e6fa74228ee/src/serve-static.ts#L56-L59

Therefore I think we should be to silently return null if the file does not exist, even in deno.

diff --git a/src/adapter/deno/serve-static.ts b/src/adapter/deno/serve-static.ts
index b037466b..9fb577bd 100644
--- a/src/adapter/deno/serve-static.ts
+++ b/src/adapter/deno/serve-static.ts
@@ -16,6 +16,11 @@ export const serveStatic = <E extends Env = Env>(
         // eslint-disable-next-line @typescript-eslint/no-explicit-any
         return file ? (file.readable as any) : null
       } catch (e) {
+        // eslint-disable-next-line @typescript-eslint/ban-ts-comment
+        // @ts-ignore
+        if (e instanceof Deno.errors.NotFound) {
+          return null // do not report error
+        }
         console.warn(`${e}`)
       }
     }

I don't think we need to change the extension definition now.

[yusukebe]

@usualoma Thank you for the comment!

As I understand it, the problem is that console.warn() is called when the file does not exist, in Deno.

Indeed, Bun's and Deno's implementations differ. Bun's serve static does not show the error.

But I intended it to show the not found error, making the user quickly debug, though Bun's is not showing it now.

In this case, the problem is if accessing the URLs will be access to the following file paths:

• /static/foo.bar_index => ./static/foo.bar_index/index.html // not found
• /static/foo.bar-index => ./static/foo.bar-index/index.html // not found

Ideally, if access to /static/foo.bar_index, ./static/foo.bar_index will be looked up. So, the change in this PR is preferred.

[usualoma]

@yusukebe
I understood the situation from your explanation. Sorry for making you spend so much time.
I think it's good!

[yusukebe]

@usualoma Thanks!