-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: add recipients sweeper #516
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #516 +/- ##
=======================================
Coverage 80.13% 80.13%
=======================================
Files 72 72
Lines 5557 5557
=======================================
Hits 4453 4453
Misses 810 810
Partials 294 294 ☔ View full report in Codecov by Sentry. |
dstrelau
approved these changes
Jul 30, 2024
jharley
commented
Jul 30, 2024
@@ -35,7 +35,7 @@ linters: | |||
- unconvert | |||
- unparam | |||
- unused | |||
- vet | |||
- govet |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
vet
linter is deprecated
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds Sweepers to the project with an initial sweeper for recipients (which seem to cause the most test failures/conflicts).
This also attempts to get all recipients named with a
test.
prefix (#test.
for Slack recipients) establishing the convention that if a thing's name starts withtest.
is can be "swept".