Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add recipients sweeper #516

Merged
merged 6 commits into from
Jul 30, 2024
Merged

chore: add recipients sweeper #516

merged 6 commits into from
Jul 30, 2024

Conversation

jharley
Copy link
Collaborator

@jharley jharley commented Jul 30, 2024

Adds Sweepers to the project with an initial sweeper for recipients (which seem to cause the most test failures/conflicts).

This also attempts to get all recipients named with a test. prefix (#test. for Slack recipients) establishing the convention that if a thing's name starts with test. is can be "swept".

@jharley jharley marked this pull request as ready for review July 30, 2024 20:43
@jharley jharley requested a review from a team as a code owner July 30, 2024 20:43
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.13%. Comparing base (33da866) to head (9745e37).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #516   +/-   ##
=======================================
  Coverage   80.13%   80.13%           
=======================================
  Files          72       72           
  Lines        5557     5557           
=======================================
  Hits         4453     4453           
  Misses        810      810           
  Partials      294      294           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@@ -35,7 +35,7 @@ linters:
- unconvert
- unparam
- unused
- vet
- govet
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

vet linter is deprecated

@jharley jharley merged commit ef618d2 into main Jul 30, 2024
6 checks passed
@jharley jharley deleted the jharley.test-sweepers branch July 30, 2024 21:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Sweepers for test cleanup
3 participants