fix: flaky TestOriginalSampleRateIsNotedInMetaField #991
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robbkidd
force-pushed
the
robb.flappy-test
branch
from
0a636b9 to
60b2086
Compare
robbkidd
force-pushed
the
robb.flappy-test
branch
from
60b2086 to
995128b
Compare
robbkidd
added
the
version: no bump
VinozzZ
reviewed
Feb 13, 2024
collect/collect_test.go
Outdated
| coll.AddSpan(span) | ||
| // Find the Refinery-sampled-and-sent event that had no upstream sampling which | ||
| // should be the last event on the transmission queue. | ||
| var noUpstreamSampleRateEvent *types.Event | ||
| assert.Eventually(t, func() bool { |
There was a problem hiding this comment.
I know you didn't change this part of the test in this PR. I'm just wondering if using require instead of assert here would be easier to identify failures here. If the assertion for "no-upstream-stampling has failed, the following check won't succeed either.
There was a problem hiding this comment.
I'm a big fan of require—this PR adds it to this test file—and I'm not sure why I didn't use it here.
kentquirk
approved these changes
Feb 13, 2024
require makes it more clear that the test failed because the event needed for the later assertion never appeared.
VinozzZ
approved these changes
Feb 14, 2024
|
Me liberally sprinkling tests and code comments everywhere. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Short description of the changes