feat: use a computed field for current descendant count in rules #950
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kentquirk
approved these changes
Dec 14, 2023
VinozzZ
force-pushed
the
yingrong.create_computed_field_on_traces
branch
from
70114af to
d664e52
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Metadata about a trace is added only to root spans. However, it's useful to make sampling decisions before root span arrives. In this PR, I addressed a specific use case described in this issue
Short description of the changes
This PR adds a new concept called
ComputedFieldin rule based sampler. AComputedFieldis a virtual field that's generated during rule evaluation for a trace. The virtual field isn't actually defined on a span.After some discussion with Kent, we decided to use
?.as the prefix for computed field so that it shouldn't collide with any regular field names.This PR doesn't include documentation. I will address it in this PR for all rules related documentation.