fix: Don't fatal error when we can return an error #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kentquirk
changed the title
| @@ -625,8 +625,7 @@ func ConfigureOpenTelemetry(opts ...Option) (func(), error) { | |||
| for _, setup := range []setupFunc{setupTracing, setupMetrics} { | |||
| shutdown, err := setup(c) | |||
| if err != nil { | |||
| c.Logger.Fatalf("setup error: %v", err) | |||
| continue | |||
| return otelConfig.Shutdown, fmt.Errorf("setup error: %w", err) | |||
There was a problem hiding this comment.
Do you think it would be worth capturing all the errors from the for loop, combing them and returning a single error?
There was a problem hiding this comment.
I didn't see it as worthwhile, since upstream would have to be told to expect some form of multierror. I saw this loop as simple convenience and considered even unrolling it. But I can do that if you prefer.
There was a problem hiding this comment.
I think returning early is fine. Thanks for putting together 👍🏻
MikeGoldsmith
approved these changes
May 3, 2023
|
@MikeGoldsmith for releasing purposes, is this a patch/bugfix you think? |
vreynolds
added
version: bump minor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Calling this code:
Crashes with a fatal error, even though the function returns an error.
It would be nice to be able to catch this error and handle it in my app appropriately.
Short description of the changes
Return a wrapped error instead of crashing. Note that this also affects other setup-type errors that are currently fatally crashing, and required reworking some tests.
How to verify that this has the expected result
Run the tests, or the code above;
errshould come back as non-nil and it shouldn't crash.