Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(plugin-core): print source map revisions message #1418

Merged
merged 2 commits into from
Nov 22, 2024

Conversation

subzero10
Copy link
Member

Status

READY

Description

Prints a message on successful source maps upload to remind users that Honeybadger needs to be configured with the same revision in order for source maps to match.

Closes: #1417

@subzero10 subzero10 requested a review from joshuap November 16, 2024 16:37
@subzero10 subzero10 self-assigned this Nov 16, 2024
@subzero10 subzero10 changed the title chore(plugin-code): print source map revisions message chore(plugin-core): print source map revisions message Nov 18, 2024
packages/plugin-core/src/sourcemaps.ts Outdated Show resolved Hide resolved
@subzero10 subzero10 requested a review from joshuap November 21, 2024 07:00
Copy link
Member

@joshuap joshuap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!!

@subzero10 subzero10 merged commit de689ac into master Nov 22, 2024
9 checks passed
@subzero10 subzero10 deleted the source-maps-message-1417 branch November 22, 2024 07:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Print console message on source maps upload to remind users that revisions need to match
2 participants