Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(webpack): rely on plugin-core #1211

Merged
merged 14 commits into from
Oct 23, 2023
Merged

feat(webpack): rely on plugin-core #1211

merged 14 commits into from
Oct 23, 2023

Conversation

BethanyBerkowitz
Copy link
Contributor

@BethanyBerkowitz BethanyBerkowitz commented Oct 13, 2023 •
edited
Loading

Status

READY

Description

Closes #1013

Related PRs

#1193
#1195

Todos

  • Tests
  • Documentation
  • Manual testing of multiple sourcemap file upload
  • Modify the example project to have sourcemaps actually get applied to an error -- this would make us more confident that the upload worked correctly
  • Manual testing of behavior when sourcemap upload fails

Steps to Test or Reproduce

In /webpack

npm run build

In /webpack/example

npm run build

You should see happy logging.
Screen Shot 2023-10-13 at 4 08 10 PM

You should see the deployment and sourcemap file in the Honeybadger UI.

@BethanyBerkowitz
Copy link
Contributor Author

Tested uploading multiple files:
Screen Shot 2023-10-16 at 12 04 23 PM

Tested upload failures -- it looks the same as on master so I think we're good.
Screen Shot 2023-10-16 at 12 15 57 PM

@BethanyBerkowitz
Copy link
Contributor Author

Sourcemaps applied!
Screen Shot 2023-10-16 at 12 56 53 PM

subzero10
subzero10 previously approved these changes Oct 20, 2023
View reviewed changes
Copy link
Member

@subzero10 subzero10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking great!
It's impressive to see how much the code is reduced in this package now and it's only specific to the webpack plugin.

packages/webpack/example/webpack.config.js
localUsername: 'hbTestUser',
}
}),
// Be aware that if you use EnvironmentPlugin, the values of those env variables
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

packages/webpack/test/HoneybadgerSourceMapPlugin.test.js Show resolved Hide resolved
@BethanyBerkowitz BethanyBerkowitz enabled auto-merge (squash) October 23, 2023 14:22
@BethanyBerkowitz BethanyBerkowitz merged commit 6730df8 into master Oct 23, 2023
13 checks passed
@BethanyBerkowitz BethanyBerkowitz deleted the BKB/webpack-plugin-core branch October 23, 2023 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@subzero10 subzero10 subzero10 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Extract shared plugin code and share between rollup and webpack plugins
2 participants
@BethanyBerkowitz @subzero10