Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(react-native): react native unit testing setup #1090

Merged
merged 12 commits into from
Jun 21, 2023

Conversation

BethanyBerkowitz
Copy link
Contributor

@BethanyBerkowitz BethanyBerkowitz commented Jun 12, 2023

Status

READY

Description

Closes #902.

It includes:

  1. Jest setup
  2. androidUtils testing
  3. iosUtils testing (more would be helpful, see note in the file)
  4. transport testing

It does not include testing on index.ts, which can go in a follow-up PR.

Steps to Test or Reproduce

Outline the steps to test or reproduce the PR here.

cd packages/react-native
npm install
npm test

@vercel
Copy link

vercel bot commented Jun 12, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
app-router-example-app ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 14, 2023 2:20pm
pages-router-example-app ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 14, 2023 2:20pm

@BethanyBerkowitz
Copy link
Contributor Author

Checked that the new tests ran in CI. There's an issue with NextJS example app deployment which is not related to this PR.

@subzero10
Copy link
Member

Checked that the new tests ran in CI. There's an issue with NextJS example app deployment which is not related to this PR.

The nextjs example app deployments should not be running with these PRs 🤔 .
I disconnected them now so it should be OK.

@subzero10
Copy link
Member

Thank you @BethanyBerkowitz!

Hopefully with the added unit tests we will go away from the discussions of "was this supposed to work like this?" or "is this functionality necessary/redundant?"

@BethanyBerkowitz BethanyBerkowitz merged commit f0d3617 into master Jun 21, 2023
@BethanyBerkowitz BethanyBerkowitz deleted the BKB/react-native-testing branch June 21, 2023 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Set up Jest testing for React Native
3 participants