Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AWS Lambda Integration: async handler #677

Closed
subzero10 opened this issue Dec 28, 2021 Discussed in #674 · 3 comments
Closed

AWS Lambda Integration: async handler #677

subzero10 opened this issue Dec 28, 2021 Discussed in #674 · 3 comments
Assignees
@subzero10
Milestone
4.0.0

Comments

@subzero10
Copy link
Member

subzero10 commented Dec 28, 2021 •
edited
Loading

Discussed in #674

Improve implementation of callback based and async (promise based) lambda handlers.

  • Modify lambdaHandler to return async handler instead of callback based handler.

Question: Should this be a major release?
@subzero10 subzero10 self-assigned this Dec 28, 2021
subzero10 added a commit that referenced this issue Dec 30, 2021
@subzero10
change lambdaHandler wrapper to return async handler #677
d6400fe
@subzero10 subzero10 mentioned this issue Dec 30, 2021
Merged
10 tasks
@shalvah
Copy link
Contributor

shalvah commented Dec 31, 2021 •
edited
Loading

Should this be a major release?

By itself, hopefully not. But if we go ahead to replace all the callback code in the package with promises, then perhaps.

@subzero10
Copy link
Member Author

Should this be a major release?

By itself, hopefully not. But if we go ahead to replace all the callback code in the package with promises, then perhaps.

We are not replacing all code with promises in this PR but we are going to be returning a promise-based lambda handler instead of callback-based.

@subzero10 subzero10 mentioned this issue Jan 10, 2022
Closed
joshuap pushed a commit that referenced this issue Feb 2, 2022
@subzero10
Improve Honeybadger.lambdaHandler() to return async handler (#680)
7ea5fb7 
* change lambdaHandler wrapper to return async handler #677

* aws lambda example project

* README in example project and CHANGELOG

* add temp logs

* fix README

* throw err in afterNotify

* debugging new aws lambda handler impl

* debugging new aws lambda handler impl

* adding logs

* wip

* wip

* remove aws default listener

* remove aws default listener

* remove logs

* remove logs

* #327 notifyAsync (#684)

* notifyAsync + tests

* simplify implementation

* changelog

* add test

* revert to original implementation + test

* update tests

* return isomorphic handler + tests

* make input and output generic in handler

* use any so users will not be forced to specify type

* CHANGELOG.md

* aws lambda example project, point to future version
@subzero10 subzero10 added this to the 4.0.0 milestone Apr 3, 2022
@subzero10
Copy link
Member Author

This has been released with v4 (currently in beta).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@subzero10 subzero10

Labels
None yet
Projects
None yet
Milestone
4.0.0
Development

No branches or pull requests
2 participants
@subzero10 @shalvah