Submodule Registry Integration #215
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* market verified creator wip * add temp debt fix | remove logs | add constants for validation | add remainder markets for future risk funcs * adjust market constants * wip loanhelpers * add verified creator in validation * filter empty pos * verfied creators * update honey sdk * remove unnecessary params * remove unnecessary params and code * add description * interestrate wip * set max ratio to 100% * remove logs * downgrade package @jup-ag/react-hook * remove logs * add logs * add discounted base borrow rate * add market id for getinterest rate func * add collection id for get interest rate * add default market for interest rate and todo before dashboard goes live to update func. with dynamic market ids * add discount borrow rate for lifinity and atadians * add comments * change func. name * remove unused code | add coments | remove dependencies from array * remove log and comment * allow column to open when no wallet is connected * add more comments |comment setup * remove code | add comments | add verified creator * add verified creator for deposit nft func * add local log * remove log * update UI after deposit withdraw * local testing with fetchPositionBids * add filter function to filter out all nfts that do not include verified creator * adjust image array * remove commented statements * remove commented code | add comments * add comments * remove non used imports | add comments * add comments * add comments | remove duplication * remove imports | add comments * add comments * remove unused code * adjust and add types * remove unused code | add comments | add creators * add comment * add type | rename item to NFT | add comment * adjust comment * add comments | remove imports and unused code | remove await * add comments | remove unused imports * remove unused code * add constants for BSL * add bsl market id * remove unused imports * add BSL to markets * add BSL to helper functions * adjust imports | move constants from constants to helpers/marketHelpers | remove unused imports | add comment * add log * fix interest rate * fix interest rate * remove bsl from markets * adjust path * adjust import * add constants object * adjust set market func * adjust imports | func param call | constants and market setup Co-authored-by: Bowtiedpyro <[email protected]>
|
@bbroeking is attempting to deploy a commit to the Honey Labs Team on Vercel. To accomplish this, @bbroeking needs to request access to the Team. Afterwards, an owner of the Team is required to accept their membership request. If you're already a member of the respective Vercel Team, make sure that your Personal Vercel Account is connected to your GitHub account. |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
An owner of the Honey Labs Team on Vercel accepted @bbroeking's request to join. @bbroeking's commit is now being deployed. |
|
Looks good @bbroeking - we can merge this in. |
@bowtiedpyro I'll resolve the merge conflicts, but I think there's still 2 things to address. Not sure how to include the git submodule in the next build such that it's images are useable. Also I think some of the new render logic is breaking the lend page |
bbroeking
commented
Dec 12, 2022
.github/workflows/update.yml
Outdated
| on: | ||
| # Triggers the workflow on push or pull request events but only for the "main" branch | ||
| push: | ||
| branches: ['main', 'feature/submodule-registry-integ'] |
There was a problem hiding this comment.
will need to add any other branches
bbroeking
commented
Dec 12, 2022
| on: | ||
| # Triggers the workflow on push or pull request events but only for the "main" branch | ||
| push: | ||
| branches: ['main'] |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
two more things to check