fix(network): dead lock in peer manager (nervosnetwork#24)

Don't use if-let
homura · Oct 18, 2019 · a74017a · a74017a
1 parent 1691bfa
commit a74017a
Showing 1 changed file with 4 additions and 2 deletions.
diff --git a/core/network/src/peer_manager/mod.rs b/core/network/src/peer_manager/mod.rs
@@ -276,8 +276,10 @@ impl Inner {
     }
 
     pub fn try_remove_addr(&self, addr: &Multiaddr) {
-        if let Some(pid) = self.addr_pid.read().get(addr) {
-            self.remove_peer_addr(&pid.clone(), addr);
+        let opt_pid = self.addr_pid.read().get(addr).cloned();
+
+        if let Some(pid) = opt_pid {
+            self.remove_peer_addr(&pid, addr);
         }
     }