Adding user session check to exec.cgi #31
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change adds a first version of user session check and validation. Login in WegUI to get a valid sessionID to be able to call ```/addons/xmlapi/exec.cgi?sid=....``` ToDo: User authorisation level check (Admin, User or Guest) needs to be added. Currently the guest level can use the script, too. But better a valid login session than nothing. Disclaimer: I just added the login session check as a kind of proof of concept. I did not check any negative impact to existing tools or scripts. Both TCL scripts were copied from rdmtc/RedMatic/blob/master/addon_files/redmatic/lib/
|
First PR to issue #29 |
|
This PR is obsolete since within the upcoming v2 version of XML-API a token-based authentication scheme had been added which should prevent these kind of issues. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds a first version of user session check and validation.
Login in WegUI to get a valid sessionID to be able to call
/addons/xmlapi/exec.cgi?sid=....ToDo: User authorisation level check (Admin, User or Guest) needs to be
added.
Currently the guest level can use the script, too.
But better a valid login session than nothing.
Disclaimer: I just added the login session check as a kind of proof of
concept. I did not check any negative impact to existing tools or
scripts.
Both TCL scripts were copied from
https://github.com/rdmtc/RedMatic/tree/master/addon_files/redmatic/lib/